Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for non-H1 headers #18

Merged
merged 2 commits into from
Sep 5, 2016
Merged

Allow for non-H1 headers #18

merged 2 commits into from
Sep 5, 2016

Conversation

dwijnand
Copy link
Member

Fixes #17

@dwijnand
Copy link
Member Author

dwijnand commented Sep 1, 2016

/review by @eed3si9n, @pvlugter

@eed3si9n
Copy link
Contributor

eed3si9n commented Sep 5, 2016

LGTM

@eed3si9n eed3si9n merged commit effa0b3 into lightbend:master Sep 5, 2016
@dwijnand dwijnand deleted the h2 branch September 5, 2016 18:23
@pvlugter
Copy link
Member

pvlugter commented Sep 5, 2016

LGTM2.

I'm trying to remember why it was restricted to H1 — it was obviously a conscious decision — but I can't think what it was for now. I see there's a TODO: get default label node from page index link? comment, so maybe that was the original idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwijnand @eed3si9n @pvlugter